comphead commented on PR #8193: URL: https://github.com/apache/arrow-datafusion/pull/8193#issuecomment-1821665317
Thanks @alamb this is my fault, I referenced too much problems and brought up the confusion. This particular PR has nothing to do INT96 and Parquet, it relates to timestamp literals only. It fixes next problems - to handle integer the same way as PG, DuckDB, Spark, etc - negative ops extended for timestamps - align all timestamp syntaxes to return consistent result and same datatypes. I have returned the signature to be NanoSecond like it was before, and now everything timestamp related in DF is consistent. We still have problems with overflows on extreme high/low values which can be fixed with either: - change default timestamp precision to microsecond instead of nanosecond, this might be huge work involved, as all timestamp arithmetics refers to NanoSeconds - change Timestamp underlying storage to `i128` instead of `i64` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
