niyue commented on PR #38873: URL: https://github.com/apache/arrow/pull/38873#issuecomment-1825648726
@kou I submit this PR to address the follow up task mentioned in https://github.com/apache/arrow/pull/38632#discussion_r1388576545. But after I finish most of the refactoring, I realize the template function may still be needed since the function holder map requires returning a parent class shared_ptr (FunctionHolderPtr) but each FunctionHolder sub class's `Make` returns a concrete class shared_ptr. But this PR at least reduces 80 lines of code, so I think it may still be useful and submit it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
