niyue commented on code in PR #38873:
URL: https://github.com/apache/arrow/pull/38873#discussion_r1407651953
##########
cpp/src/gandiva/regex_functions_holder.cc:
##########
@@ -132,12 +131,11 @@ Status LikeHolder::Make(const std::string& sql_pattern,
Status::Invalid("Building RE2 pattern '", pcre_pattern,
"' failed with: ", lholder->regex_.error()));
- *holder = std::move(lholder);
- return Status::OK();
+ return std::move(lholder);
Review Comment:
Thanks for pointing it out. I change several usages I can find in the
codebase (all in the same file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
