niyue commented on code in PR #38873:
URL: https://github.com/apache/arrow/pull/38873#discussion_r1404335496
##########
cpp/src/gandiva/to_date_holder.cc:
##########
@@ -51,7 +50,7 @@ Status ToDateHolder::Make(const FunctionNode& node,
if (node.children().size() == 3) {
auto literal_suppress_errors =
dynamic_cast<LiteralNode*>(node.children().at(2).get());
- if (literal_pattern == nullptr) {
+ if (literal_suppress_errors == nullptr) {
Review Comment:
This is a bug for `to_date_holder` I found accidentally during the
refactoring. The `literal_pattern` is always **not** `nullptr` since line 37
already check if it is `nullptr`. And the code here would like to check the
third parameter (according to the error reported below), which should be
`literal_suppress_errors` I believe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
