niyue commented on code in PR #38873:
URL: https://github.com/apache/arrow/pull/38873#discussion_r1407674648
##########
cpp/src/gandiva/regex_functions_holder_test.cc:
##########
@@ -330,16 +289,14 @@ class TestReplaceHolder : public ::testing::Test {
};
TEST_F(TestReplaceHolder, TestMultipleReplace) {
- std::shared_ptr<ReplaceHolder> replace_holder;
-
- auto status = ReplaceHolder::Make("ana", &replace_holder);
- EXPECT_EQ(status.ok(), true) << status.message();
+ auto replace_holder = ReplaceHolder::Make("ana");
+ EXPECT_EQ(replace_holder.ok(), true) << replace_holder.status().message();
Review Comment:
Sure. I changed some of such usages in these several test files now I change
more such usages I find.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
