comphead commented on code in PR #8402:
URL: https://github.com/apache/arrow-datafusion/pull/8402#discussion_r1413165706


##########
datafusion/sqllogictest/test_files/window.slt:
##########
@@ -3727,3 +3727,24 @@ FROM score_board s
 
 statement ok
 DROP TABLE score_board;
+
+# test window spec PARTITION BY/ORDER BY for scalar values should be ignored, 
only scalars in window spec
+# single row
+query III
+select a, 
+       rank() over (partition by 10, 'a', null order by 20, 10, 'a', null) rnk,
+       row_number() over (partition by 10, 'a', null order by 20, 10, 'a', 
null) rn
+       from (select 1 a) q

Review Comment:
   Thanks @haohuaijin 'll do. Before that I was confused 
(https://github.com/apache/arrow-datafusion/issues/8403#issuecomment-1837473877)
 and thought it is another bug so made a row level workaround. I was able to 
reproduce the same in DuckDB so this is expected, not a bug I'll fix the test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to