viirya commented on code in PR #8402:
URL: https://github.com/apache/arrow-datafusion/pull/8402#discussion_r1413194074
##########
datafusion/sql/src/expr/function.rs:
##########
@@ -90,10 +91,30 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let partition_by = window
.partition_by
.into_iter()
+ // ignore window spec PARTITION BY for scalar values
+ .filter(|e| !matches!(e, sqlparser::ast::Expr::Value { .. }))
.map(|e| self.sql_expr_to_logical_expr(e, schema,
planner_context))
.collect::<Result<Vec<_>>>()?;
- let order_by =
- self.order_by_to_sort_expr(&window.order_by, schema,
planner_context)?;
+
+ let order_by = self.order_by_to_sort_expr(
+ &window
+ .order_by
+ .into_iter()
+ // ignore window spec ORDER BY for scalar values
+ .filter(|e| {
+ !matches!(
+ e,
+ OrderByExpr {
+ expr: sqlparser::ast::Expr::Value { .. },
+ ..
+ }
+ )
Review Comment:
How did you test it? Did you use RANGE frame? It must be RANGE that triggers
the error:
```
query error DataFusion error: Error during planning: RANGE requires exactly
one ORDER BY column
select a,
rank() over (partition by a order by 1 RANGE 10 PRECEDING) rnk
from (select 1 a union all select 2 a) q
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
