niyue commented on code in PR #39098:
URL: https://github.com/apache/arrow/pull/39098#discussion_r1417010832
##########
cpp/src/gandiva/engine.cc:
##########
@@ -163,114 +237,50 @@ Status Engine::LoadFunctionIRs() {
}
/// factory method to construct the engine.
-Status Engine::Make(const std::shared_ptr<Configuration>& conf, bool cached,
- std::unique_ptr<Engine>* out) {
+Result<std::unique_ptr<Engine>> Engine::Make(
+ const std::shared_ptr<Configuration>& conf, bool cached,
+ std::optional<std::reference_wrapper<GandivaObjectCache>> object_cache) {
std::call_once(llvm_init_once_flag, InitOnce);
- auto ctx = std::make_unique<llvm::LLVMContext>();
- auto module = std::make_unique<llvm::Module>("codegen", *ctx);
-
- // Capture before moving, ExecutionEngine does not allow retrieving the
- // original Module.
- auto module_ptr = module.get();
-
- auto opt_level =
- conf->optimize() ? llvm::CodeGenOpt::Aggressive : llvm::CodeGenOpt::None;
-
- // Note that the lifetime of the error string is not captured by the
- // ExecutionEngine but only for the lifetime of the builder. Found by
- // inspecting LLVM sources.
- std::string builder_error;
-
- llvm::EngineBuilder engine_builder(std::move(module));
-
- engine_builder.setEngineKind(llvm::EngineKind::JIT)
- .setOptLevel(opt_level)
- .setErrorStr(&builder_error);
-
- if (conf->target_host_cpu()) {
- engine_builder.setMCPU(cpu_name);
- engine_builder.setMAttrs(cpu_attrs);
- }
- std::unique_ptr<llvm::ExecutionEngine> exec_engine{engine_builder.create()};
-
- if (exec_engine == nullptr) {
- return Status::CodeGenError("Could not instantiate llvm::ExecutionEngine:
",
- builder_error);
- }
Review Comment:
Move the logic into `GetTargetMachineBuilder` and `BuildJIT` functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
