niyue commented on code in PR #39098:
URL: https://github.com/apache/arrow/pull/39098#discussion_r1417408376
##########
python/pyarrow/gandiva.pyx:
##########
@@ -186,10 +186,6 @@ cdef class Projector(_Weakrefable):
self.pool = pool
return self
- @property
- def llvm_ir(self):
- return self.projector.get().DumpIR().decode()
Review Comment:
I have to remove the `llvm_ir` API from python binding, since the
`Configuration` is not exposed via the `make_projector` and `make_filter` APIs,
but we may consider adding it if we can expose the `Configuration` as well
##########
python/pyarrow/gandiva.pyx:
##########
@@ -186,10 +186,6 @@ cdef class Projector(_Weakrefable):
self.pool = pool
return self
- @property
- def llvm_ir(self):
- return self.projector.get().DumpIR().decode()
Review Comment:
I have to remove the `llvm_ir` API from python binding, since the
`Configuration` is not exposed via the `make_projector` and `make_filter` APIs,
but we may consider adding it back if we can expose the `Configuration` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
