niyue commented on code in PR #39098:
URL: https://github.com/apache/arrow/pull/39098#discussion_r1417033097
##########
cpp/src/gandiva/engine_llvm_test.cc:
##########
@@ -24,14 +24,14 @@
namespace gandiva {
-typedef int64_t (*add_vector_func_t)(int64_t* data, int n);
+using add_vector_func_t = int64_t (*)(int64_t*, int);
class TestEngine : public ::testing::Test {
protected:
- std::string BuildVecAdd(Engine* engine) {
- auto types = engine->types();
- llvm::IRBuilder<>* builder = engine->ir_builder();
- llvm::LLVMContext* context = engine->context();
+ std::string BuildVecAdd(Engine* gdv_engine) {
Review Comment:
The `engine` param is renamed to `gdv_engine` since it shadows the `engine`
member variable in this class which introduces unnecessary confusion here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
