tustvold commented on code in PR #5178:
URL: https://github.com/apache/arrow-rs/pull/5178#discussion_r1417948381
##########
parquet/src/arrow/array_reader/primitive_array.rs:
##########
@@ -26,22 +25,55 @@ use crate::errors::{ParquetError, Result};
use crate::schema::types::ColumnDescPtr;
use arrow_array::Decimal256Array;
use arrow_array::{
- builder::{BooleanBufferBuilder, TimestampNanosecondBufferBuilder},
- ArrayRef, BooleanArray, Decimal128Array, Float32Array, Float64Array,
Int32Array,
- Int64Array, TimestampNanosecondArray, UInt32Array, UInt64Array,
+ builder::TimestampNanosecondBufferBuilder, ArrayRef, BooleanArray,
Decimal128Array,
+ Float32Array, Float64Array, Int32Array, Int64Array,
TimestampNanosecondArray, UInt32Array,
+ UInt64Array,
};
-use arrow_buffer::{i256, Buffer};
+use arrow_buffer::{i256, BooleanBuffer, Buffer};
use arrow_data::ArrayDataBuilder;
use arrow_schema::{DataType as ArrowType, TimeUnit};
use std::any::Any;
use std::sync::Arc;
+/// Provides conversion from `Vec<T>` to `Buffer`
+pub trait IntoBuffer {
Review Comment:
This whole module is crate private, so this isn't a breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
