tustvold commented on code in PR #5178:
URL: https://github.com/apache/arrow-rs/pull/5178#discussion_r1417949047
##########
parquet/src/arrow/record_reader/buffer.rs:
##########
@@ -37,12 +33,12 @@ pub trait BufferQueue: Sized {
/// to append data to the end of this [`BufferQueue`]
///
/// NB: writes to the returned slice will not update the length of
[`BufferQueue`]
- /// instead a subsequent call should be made to [`BufferQueue::set_len`]
- fn spare_capacity_mut(&mut self, batch_size: usize) -> &mut Self::Slice;
+ /// instead a subsequent call should be made to
[`BufferQueue::truncate_buffer`]
+ fn get_output_slice(&mut self, batch_size: usize) -> &mut Self::Slice;
Review Comment:
I opted to rename these methods so they didn't collide with methods on Vec.
Eventually the plan with #5178 is to remove the need for this trait entirely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
