tustvold commented on code in PR #5178:
URL: https://github.com/apache/arrow-rs/pull/5178#discussion_r1417948639
##########
parquet/src/arrow/record_reader/buffer.rs:
##########
@@ -57,132 +53,27 @@ pub trait BufferQueue: Sized {
/// track how much of this slice is actually written to by the caller.
This is still
/// safe as the slice is default-initialized.
///
- fn set_len(&mut self, len: usize);
-}
-
-/// A marker trait for [scalar] types
-///
-/// This means that a `[Self::default()]` of length `len` can be safely
created from a
-/// zero-initialized `[u8]` with length `len * std::mem::size_of::<Self>()` and
-/// alignment of `std::mem::size_of::<Self>()`
-///
-/// [scalar]:
https://doc.rust-lang.org/book/ch03-02-data-types.html#scalar-types
-///
-pub trait ScalarValue: Copy {}
Review Comment:
This module is crate-private and so this is not a breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
