emkornfield commented on code in PR #39153:
URL: https://github.com/apache/arrow/pull/39153#discussion_r1423509985
##########
cpp/src/parquet/column_reader.h:
##########
@@ -368,6 +368,11 @@ class PARQUET_EXPORT RecordReader {
virtual void DebugPrintState() = 0;
+ /// \brief Returns the dictionary owned by the current decoder. Throws an
+ /// exception if the current decoder is not for dictionary encoding.
+ /// \param[out] dictionary_length The number of dictionary entries.
+ virtual const void* ReadDictionary(int32_t* dictionary_length) = 0;
Review Comment:
I think it should be possible to make this templated (with implementations
in the .cc file? If so I think that might make sense for consumers. Either
way we should clarify how users can understand what to case the dictionary to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
