jp0317 commented on PR #39153: URL: https://github.com/apache/arrow/pull/39153#issuecomment-1854511035
> Some remaining question: What would it expect todo with non-bytearray types, like int32? oh sorry, missed the last comment. The new `GetDictionary` itself would work as long as the internal decoder is a dictionary decoder, regardless of types. The issue is that current record reader only `read_dictionary` for byte array (i.e., the `values()` always returns decoded values and `read_dictionary()` returns false for non byte-array, and that's why I target byte array in this pr). I think it probably makes sense to extend the `read_dictionary` for other types in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
