kou commented on code in PR #39098:
URL: https://github.com/apache/arrow/pull/39098#discussion_r1429269659
##########
cpp/src/gandiva/engine.cc:
##########
@@ -454,10 +555,9 @@ arrow::Status Engine::AddGlobalMappings() {
}
std::string Engine::DumpIR() {
Review Comment:
OK. How about adding new `const std::string& Engine::ir()` and keeping
`ARROW_DEPRECATED("Deprecated in 15.0.0. Use ir() instead.") std::string
Engine:::DumpIR() {return ir();}` for backward compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
