zanmato1984 commented on issue #36246: URL: https://github.com/apache/arrow/issues/36246#issuecomment-1863783116
I did some investigation on this. With the change drafted in #39312, the result shows a small reduction on build time (1350.7s VS. 1298.6s) and a noticeable reduction on the inclusion of `function.h` (not showing up in expensive headers section). The experiment is conducted on my local Mac M1, building in `ninja-debug` preset and using `ninja all` command. Here attached detailed analysis results before and after #39312 : [analyze-after.txt](https://github.com/apache/arrow/files/13722431/analyze-after.txt) [analyze-before.txt](https://github.com/apache/arrow/files/13722432/analyze-before.txt) I'm not sure if we should proceed with the PR though. cc @pitrou @westonpace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
