zanmato1984 commented on issue #36246: URL: https://github.com/apache/arrow/issues/36246#issuecomment-1863802370
Update. Found a problem in CI indicating something that we should probably pay attention to: With `function.h` removed from `api_aggregate.h` https://github.com/apache/arrow/pull/39312/files#diff-694a635f185cf0d22dd6eefd91acedb48ed0bf71b15fd591aa6e7c508ba4cb09L25-R25 the declarations in `function.h` such as `CallFunction()` will not be in `api_aggregate.h`. Then some user code which includes `api_aggregate.h` only but uses `CallFunction()` will fail compile. This is the case in this CI failure: https://github.com/apache/arrow/actions/runs/7270431142/job/19809507298?pr=39312 ``` /arrow/cpp/examples/arrow/compute_and_write_csv_example.cc:81:41: error: 'CallFunction' is not a member of 'arrow::compute'; did you mean 'Function'? ``` I'm worrying this is a breaking change. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
