alamb commented on code in PR #8604:
URL: https://github.com/apache/arrow-datafusion/pull/8604#discussion_r1433193326
##########
datafusion/core/src/datasource/listing_table_factory.rs:
##########
@@ -135,12 +135,8 @@ impl TableProviderFactory for ListingTableFactory {
let mut statement_options = StatementOptions::from(&cmd.options);
- // Extract ListingTable specific options if present or set default
- let single_file = statement_options
- .take_bool_option("single_file")?
- .unwrap_or(false);
-
- // Backwards compatibility (#8547)
+ // Backwards compatibility (#8547), discard deprecated options
Review Comment:
👍
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -797,7 +787,7 @@ impl TableProvider for ListingTable {
// all of the data at the input is sink after execution finishes.
See discussion for rationale:
//
https://github.com/apache/arrow-datafusion/pull/7610#issuecomment-1728979918
unbounded_input: is_plan_streaming(&input)?,
- single_file_output: self.options.single_file,
+ single_file_output: false,
Review Comment:
this got me thinking we can remove the option from the FileSInkConfig
itself.
However I see how that this PR is removing the `single_file` option from the
*read* side (the ListingTable) but it can also potentially be important for the
write side (aka a COPY statement)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
