devinjdangelo commented on code in PR #8604:
URL: https://github.com/apache/arrow-datafusion/pull/8604#discussion_r1433207967
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -797,7 +787,7 @@ impl TableProvider for ListingTable {
// all of the data at the input is sink after execution finishes.
See discussion for rationale:
//
https://github.com/apache/arrow-datafusion/pull/7610#issuecomment-1728979918
unbounded_input: is_plan_streaming(&input)?,
- single_file_output: self.options.single_file,
+ single_file_output: false,
Review Comment:
Yes, COPY still uses single_file_output option of the FileSinkConfig struct.
We could potentially update COPY to instead rely on inference based on the path
rather than an explicit option. E.g. copy table to file.parquet vs copy table
to folder/. Then single_file_output could be removed entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
