alamb commented on code in PR #8604:
URL: https://github.com/apache/arrow-datafusion/pull/8604#discussion_r1433227616


##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -797,7 +787,7 @@ impl TableProvider for ListingTable {
             // all of the data at the input is sink after execution finishes. 
See discussion for rationale:
             // 
https://github.com/apache/arrow-datafusion/pull/7610#issuecomment-1728979918
             unbounded_input: is_plan_streaming(&input)?,
-            single_file_output: self.options.single_file,
+            single_file_output: false,

Review Comment:
   🤔  that certainly would be a better UX in my opinion (figuring out to use 
SINGLE_FILE  in 
https://github.com/apache/arrow-datafusion/blob/98a5a4eb1ea1277f5fe001e1c7602b37592452f1/datafusion/sqllogictest/test_files/repartition_scan.slt#L35-L38
 was actually quite painful for me)
   
   Shall I propose a ticket to do it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to