yahoNanJing commented on code in PR #8669:
URL: https://github.com/apache/arrow-datafusion/pull/8669#discussion_r1438602184
##########
datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs:
##########
@@ -867,25 +969,80 @@ mod tests {
false,
)],
);
-
let rgm3 = get_row_group_meta_data(
&schema_descr,
vec![ParquetStatistics::fixed_len_byte_array(
None, None, None, 0, false,
)],
);
+ let rgms = [rgm1, rgm2, rgm3];
+ // cast the type of c1 to decimal(28,3)
+ let left = cast(col("c1"), DataType::Decimal128(28, 3));
+ let expr = left.eq(lit(ScalarValue::Decimal128(Some(100000), 28, 3)));
+ let expr = logical2physical(&expr, &schema);
+ let pruning_predicate = PruningPredicate::try_new(expr,
schema.clone()).unwrap();
let metrics = parquet_file_metrics();
assert_eq!(
prune_row_groups_by_statistics(
&schema,
&schema_descr,
- &[rgm1, rgm2, rgm3],
+ &rgms,
None,
Some(&pruning_predicate),
&metrics
),
vec![1, 2]
);
+ // c1 in (10, 300, 400)
Review Comment:
May bad. It should be `// c1 in (8, 300, 400)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
