yahoNanJing commented on code in PR #8669:
URL: https://github.com/apache/arrow-datafusion/pull/8669#discussion_r1438604114
##########
datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs:
##########
@@ -598,19 +662,39 @@ mod tests {
),
vec![1]
);
+
Review Comment:
If I remove the check `if has_null && value.is_null() { known_not_present =
false; break; }`, the unit test of `row_group_pruning_predicate_eq_null_expr`
would fail. Then I think the parameter `values` can be a set of one element
which is a null scalar value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
