alamb commented on PR #8669: URL: https://github.com/apache/arrow-datafusion/pull/8669#issuecomment-1872532542
> Thanks @alamb for your review and suggestions. It's my bad. Maybe multiple rules are mixed together so that the RowGroupPruningStatistics's contained implementation does not affect the final result. I will introduce independent test cases for this implementation in a few days. Thanks @yahoNanJing -- I thought about this more. What would you think about adding the code that checks the `min`/`max` statistics against `LiteralGuarantee`s for **ALL** predicates, not just the `Parquet` row statistics Perhaps we could add the check after the call to `contains` here: https://github.com/apache/arrow-datafusion/blob/cc3042a6343457036770267f921bb3b6e726956c/datafusion/core/src/physical_optimizer/pruning.rs#L245 That would have the benefits of: 1. Working for all statistics (not just Parquet) 2. Might be easier to write tests using the existing framework in pruning.rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
