jorgecarleitao commented on pull request #9301:
URL: https://github.com/apache/arrow/pull/9301#issuecomment-766163142
Now I get your point. On the PR description, I mention to _independent_
sources of unsoundness:
* we are using indices from null slots
* we are not performing bound checks on values.
In particular, the second point above allows the following code to run with
exit 0:
```rust
#[test]
fn test_bla() {
let indices = UInt32Array::from(vec![1, 10, 1000, 100000]);
let values = UInt32Array::from(vec![0, 1, 2, 3]);
let r = take(&values, &indices, None).unwrap();
println!("{:?}", r);
}
```
which of course gives a meaningless result. The point is that even though
this code is marked as `safe`, it is UB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
