Dandandan commented on pull request #9301: URL: https://github.com/apache/arrow/pull/9301#issuecomment-766173983
@jorgecarleitao yes, that's clear. I wouldn't expect a ~2x difference in performance in bounds checking alone, I would guess some other slowdown could be caused by the change to use the iterator in the `take_no_nulls` and `take_values_nulls`? Let's say we use `get_unchecked`, will it perform on par with the previous code or would it still be slower because of the other changes? We should (of course) fix any UB / uninitialized memory / etc. issues. I'm wondering if there would be good ways to detect it in more cases automatically, e.g. based on running all unit tests. Would this be detected by Miri, or not before as we didn't do any OOB in the tests? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
