Tom-Newton commented on code in PR #39450:
URL: https://github.com/apache/arrow/pull/39450#discussion_r1441482960
##########
cpp/src/arrow/filesystem/azurefs.h:
##########
@@ -92,30 +92,30 @@ struct ARROW_EXPORT AzureOptions {
private:
enum class CredentialKind {
+ kDefault,
kAnonymous,
- kTokenCredential,
- kStorageSharedKeyCredential,
- } credential_kind_ = CredentialKind::kAnonymous;
+ kStorageSharedKey,
+ kClientSecret,
+ kManagedIdentity,
+ kWorkloadIdentity,
Review Comment:
I don't think we really need to change this. I would rather just keep
`kTokenCredential` to cover all the credentials that are based on
https://github.com/Azure/azure-sdk-for-cpp/blob/e5e675440b44ace7d7a9e7bc303f877c06b59ea5/sdk/core/azure-core/inc/azure/core/credentials/credentials.hpp#L68
##########
cpp/src/arrow/filesystem/azurefs_test.cc:
##########
@@ -305,7 +317,7 @@ TEST(AzureFileSystem,
InitializeFilesystemWithManagedIdentityCredential) {
EXPECT_OK_AND_ASSIGN(fs, AzureFileSystem::Make(options));
}
Review Comment:
Should we add a test for initialising with anonymous credential?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
