felipecrv commented on code in PR #39450:
URL: https://github.com/apache/arrow/pull/39450#discussion_r1441763010


##########
cpp/src/arrow/filesystem/azurefs.h:
##########
@@ -92,30 +92,30 @@ struct ARROW_EXPORT AzureOptions {
 
  private:
   enum class CredentialKind {
+    kDefault,
     kAnonymous,
-    kTokenCredential,
-    kStorageSharedKeyCredential,
-  } credential_kind_ = CredentialKind::kAnonymous;
+    kStorageSharedKey,
+    kClientSecret,
+    kManagedIdentity,
+    kWorkloadIdentity,

Review Comment:
   We need this to support `Equals`. Think of it as runtime type-information 
that describes what concrete implementation of `TokenCredential` is being used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to