felipecrv commented on code in PR #39450:
URL: https://github.com/apache/arrow/pull/39450#discussion_r1441786157
##########
cpp/src/arrow/filesystem/azurefs.h:
##########
@@ -92,30 +92,30 @@ struct ARROW_EXPORT AzureOptions {
private:
enum class CredentialKind {
+ kDefault,
kAnonymous,
- kTokenCredential,
- kStorageSharedKeyCredential,
- } credential_kind_ = CredentialKind::kAnonymous;
+ kStorageSharedKey,
+ kClientSecret,
+ kManagedIdentity,
+ kWorkloadIdentity,
Review Comment:
Besides that, we would need to make a distinction between `kDefault` and all
the others `kToken` at least (to support the implicit default behavior). It's
clearer if we then make a distinction on all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
