clbarnes commented on PR #5222: URL: https://github.com/apache/arrow-rs/pull/5222#issuecomment-1876765449
I think that should fail a `StartTooLarge`? Byte indices are zero-based, so trying to get the byte with index 100 from a resource which is 100 bytes long is indeed starting after the end of the resource. The other off-by-one was a hangover from when I stored the right-inclusive bounds. I'll suggest another couple of changes along those lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
