clbarnes commented on PR #5222:
URL: https://github.com/apache/arrow-rs/pull/5222#issuecomment-1876774694
Ah, because I'm the author it doesn't let me suggest changes, it just puts
them right in.
```
Self::Bounded(r) => {
if r.end < r.start {
```
should be a `<=` because otherwise you're requesting a 0-length range, which
is almost certainly not what the user intends.
```
Self::Offset(o) => {
if *o > len {
```
should also be a `>=` because the index of the last byte is `len-1`, so the
byte at index `len` is also after the end of the resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
