clbarnes commented on PR #5222: URL: https://github.com/apache/arrow-rs/pull/5222#issuecomment-1876782278
> Which would imply that the logic in this PR is still overly strict True! If we want to allow the EndTooLarge case then we also need to update the `GetRange::as_range` logic to just clamp the last value. > These were changed because they were resulting in failures of existing tests, running against actual object stores. What it's running against shouldn't matter, should it? As it just catches a few extra cases where where we have requested the wrong thing. It's just a case of whether we want to allow 0-length requests, and whether we want to allow a range where the first byte is after the end of the resource. Are those tests fuzzed or are we explicitly making such requests in the tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
