crepererum commented on code in PR #8779:
URL: https://github.com/apache/arrow-datafusion/pull/8779#discussion_r1444843586


##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -83,6 +83,11 @@ macro_rules! float_distinct_count_accumulator {
     }};
 }
 
+/// Returns the estimated number of hashbrown hashtables is likely to come up 
again

Review Comment:
   ```suggestion
   /// Returns the estimated number of hashbrown hashtables.
   ```
   
   Also, can someone explain the reasoning behind this formula? Is it based on 
the hashbrown source code (in which case a link to the code would be nice)? CC 
@korowa 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to