yyy1000 commented on PR #8779: URL: https://github.com/apache/arrow-datafusion/pull/8779#issuecomment-1881842974
Ah, I have several questions that need help. :) 1. The code in `hash_join.rs` would calculate the number of rows before `Estimation of memory size` so I can't pass a HashTable as a param into the function, https://github.com/apache/arrow-datafusion/blob/819d3577872a082f2aea7a68ae83d68534049662/datafusion/physical-plan/src/joins/hash_join.rs#L717 I wonder whether it's possible to change the signature like ``` pub fn estimated_hashtable_size<T>(len: usize) -> usize { (len.checked_mul(8).unwrap_or(usize::MAX) / 7).next_power_of_two() } ``` so passing the len of a hashtable would be possible. 2. `physical-plan `seems depends on `physical-expr`, so adding the code to `arrow-datafusion/datafusion/physical-plan/src/common.rs` and add dependency in `arrow-datafusion/datafusion/physical-expr/Cargo.toml` will lead cyclic package dependency issue on my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
