korowa commented on code in PR #8779:
URL: https://github.com/apache/arrow-datafusion/pull/8779#discussion_r1445174131
##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -83,6 +83,11 @@ macro_rules! float_distinct_count_accumulator {
}};
}
+/// Returns the estimated number of hashbrown hashtables is likely to come up
again
Review Comment:
Bucket number calculation is a simplified version of
[capacity_to_buckets](https://github.com/rust-lang/hashbrown/blob/f2e62124cd947b5e2309dd6a24c7e422932aae97/src/raw/mod.rs#L195)
from hashbrown, and I'd agree that it might be helpful to mention it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
