alamb commented on code in PR #8758: URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450942251
########## benchmarks/Cargo.toml: ########## @@ -29,7 +29,6 @@ rust-version = "1.70" [features] ci = [] default = ["mimalloc"] -simd = ["datafusion/simd"] Review Comment: arrow 50 removed the manual SIMD implementation and now relies on auto vectorization - https://github.com/apache/arrow-rs/pull/5184 ########## datafusion-cli/src/exec.rs: ########## @@ -340,14 +340,6 @@ mod tests { let session_token = "fake_session_token"; let location = "s3://bucket/path/file.parquet"; - // Missing region Review Comment: Done in 5a6d80d93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
