alamb commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450946231
##########
datafusion-cli/src/exec.rs:
##########
@@ -340,13 +340,10 @@ mod tests {
let session_token = "fake_session_token";
let location = "s3://bucket/path/file.parquet";
- // Missing region
+ // Missing region, use object_store defaults
Review Comment:
object_store defaults now to us-east-1
https://github.com/apache/arrow-rs/pull/5244
##########
datafusion/sqllogictest/test_files/repartition_scan.slt:
##########
@@ -138,7 +138,7 @@ physical_plan
SortPreservingMergeExec: [column1@0 ASC NULLS LAST]
--CoalesceBatchesExec: target_batch_size=8192
----FilterExec: column1@0 != 42
-------ParquetExec: file_groups={4 groups:
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/1.parquet:0..197],
[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:0..201],
[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:201..403],
[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/1.parquet:197..394]]},
projection=[column1], output_ordering=[column1@0 ASC NULLS LAST],
predicate=column1@0 != 42, pruning_predicate=column1_min@0 != 42 OR 42 !=
column1_max@1, required_guarantees=[column1 not in (42)]
+------ParquetExec: file_groups={4 groups:
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/1.parquet:0..202],
[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:0..207],
[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:207..414],
[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/1.parquet:202..405]]},
projection=[column1], output_ordering=[column1@0 ASC NULLS LAST],
predicate=column1@0 != 42, pruning_predicate=column1_min@0 != 42 OR 42 !=
column1_max@1, required_guarantees=[column1 not in (42)]
Review Comment:
The parquet file appears to be slightly larger and thus the offsets are now
slightly different (this can happen because, for example, the metadata written
changed (instead of "arrow-rs 49.0.0" it may now say "arrow-rs 50.0.0"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
