tustvold commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450949881
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1746,6 +1746,7 @@ mod tests {
}
#[tokio::test]
+ #[ignore]
Review Comment:
We changed the way aggregates are computed and this might have impacted
buffer sizing in some way, it is hard to know for sure without investing a lot
of time. If it isn't a major change I wouldn't be overly concerned about it.
These sorts of test are always extremely fragile.
It could even be that the aggregates are now much faster and therefore we
end up buffering more, I don't know 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
