ShaiviAgarwal2 commented on code in PR #39595:
URL: https://github.com/apache/arrow/pull/39595#discussion_r1451718110
##########
matlab/CMakeLists.txt:
##########
@@ -131,6 +131,14 @@ if(NOT Arrow_FOUND)
build_arrow()
endif()
+# Identify MATLAB build mode (Debug or Release)
+if(WIN32)
+ execute_process(COMMAND dumpbin /dependents ${Matlab_MAIN_PROGRAM}
OUTPUT_VARIABLE DEPENDENTS)
Review Comment:
Should I resolve the changes? or wait for @kevingurney confirmation?
##########
matlab/CMakeLists.txt:
##########
@@ -131,6 +131,14 @@ if(NOT Arrow_FOUND)
build_arrow()
endif()
+# Identify MATLAB build mode (Debug or Release)
+if(WIN32)
+ execute_process(COMMAND dumpbin /dependents ${Matlab_MAIN_PROGRAM}
OUTPUT_VARIABLE DEPENDENTS)
Review Comment:
Should I resolve the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
