peter-toth commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1901888976
> I filed #8913 -- let me know what you think. What do you think about creating a PR with `transform_with_payload` and then a PR showing how to use it to improve one of the existing passes (or implement TreeNode::rewrite in terms of it or something?) Thanks @alamb! I will share my thoughts regarding `transform_with_payload` there. Actually I wanted to wait with `transform_with_payload` (https://github.com/apache/arrow-datafusion/pull/8664) until @ozankabak finishes https://github.com/apache/arrow-datafusion/pull/8817 as those 2 PRs are conflicting (https://github.com/apache/arrow-datafusion/pull/8664#issuecomment-1884878223). The API inconsitency of the `rewrite` API (see 1. in PR description) and the poposed new `transform` semantics (see 2.) don't requite `transform_with_payload` as a base API and this PR doesn't conflict with https://github.com/apache/arrow-datafusion/pull/8664 or https://github.com/apache/arrow-datafusion/pull/8817 so I think this PR is ready for review and feedback is welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
