ozankabak commented on code in PR #8891:
URL: https://github.com/apache/arrow-datafusion/pull/8891#discussion_r1468851397
##########
datafusion/expr/src/tree_node/expr.rs:
##########
@@ -130,13 +130,13 @@ impl TreeNode for Expr {
for child in children {
match op(child)? {
- VisitRecursion::Continue => {}
- VisitRecursion::Skip => return Ok(VisitRecursion::Continue),
- VisitRecursion::Stop => return Ok(VisitRecursion::Stop),
+ TreeNodeRecursion::Continue => {}
+ TreeNodeRecursion::Skip => return
Ok(TreeNodeRecursion::Continue),
+ TreeNodeRecursion::Stop => return Ok(TreeNodeRecursion::Stop),
Review Comment:
Seems like we can use the `handle_tree_recursion` macro here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
