lidavidm commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1465164626
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
Yes, let's just take a look and make sure - I don't care too much either way
but perhaps some of these will still be useful even after google-java-format
(since many of these seem more like lint things)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
