vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1478307482


##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
         <module name="JavadocMethod">
             <property name="scope" value="public"/>
             <property name="allowMissingParamTags" value="true"/>
-            <property name="allowMissingThrowsTags" value="true"/>
             <property name="allowMissingReturnTag" value="true"/>
-            <property name="minLineCount" value="2"/>
             <property name="allowedAnnotations" value="Override, Test"/>
-            <property name="allowThrowsTagsForSubclasses" value="true"/>
-            <!-- This seems partially broken under JDK >= 9. -->
-            <property name="suppressLoadErrors" value="true"/>
-            <property name="ignoreMethodNamesRegex" value="main"/>

Review Comment:
   > allowMissingThrowsTags, allowThrowsTagsForSubclasses, suppressLoadErrors 
are now basically the default
   
   These are not explicit properties in `8.29` but were in `8.19` but I 
couldn't find whether they are the defaults in `8.29`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to