vibhatha commented on code in PR #39694:
URL: https://github.com/apache/arrow/pull/39694#discussion_r1475865870
##########
java/dev/checkstyle/checkstyle.xml:
##########
@@ -223,14 +224,8 @@
<module name="JavadocMethod">
<property name="scope" value="public"/>
<property name="allowMissingParamTags" value="true"/>
- <property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
- <property name="minLineCount" value="2"/>
<property name="allowedAnnotations" value="Override, Test"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <!-- This seems partially broken under JDK >= 9. -->
- <property name="suppressLoadErrors" value="true"/>
- <property name="ignoreMethodNamesRegex" value="main"/>
Review Comment:
Listing compile errors for the removed attributes
1. `<property name="allowMissingThrowsTags" value="true"/>`
```bash
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on
project arrow-maven-plugins: Failed during checkstyle configuration: cannot
initialize module TreeWalker - cannot initialize module JavadocMethod -
Property 'allowMissingThrowsTags' does not exist, please check the
documentation -> [Help 1]
```
2. `<property name="minLineCount" value="2"/>`
```bash
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on
project arrow-maven-plugins: Failed during checkstyle configuration: cannot
initialize module TreeWalker - cannot initialize module JavadocMethod -
Property 'minLineCount' does not exist, please check the documentation -> [Help
1]
```
3. `<property name="allowThrowsTagsForSubclasses" value="true"/>`
```bash
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on
project arrow-maven-plugins: Failed during checkstyle configuration: cannot
initialize module TreeWalker - cannot initialize module JavadocMethod -
Property 'allowThrowsTagsForSubclasses' does not exist, please check the
documentation -> [Help 1]
```
4. `<property name="suppressLoadErrors" value="true"/>`
```bash
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on
project arrow-maven-plugins: Failed during checkstyle configuration: cannot
initialize module TreeWalker - cannot initialize module JavadocMethod -
Property 'suppressLoadErrors' does not exist, please check the documentation ->
[Help 1]
```
5. `<property name="ignoreMethodNamesRegex" value="main"/>`
```bash
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on
project arrow-maven-plugins: Failed during checkstyle configuration: cannot
initialize module TreeWalker - cannot initialize module JavadocMethod -
Property 'ignoreMethodNamesRegex' does not exist, please check the
documentation -> [Help 1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
