alamb commented on code in PR #5318:
URL: https://github.com/apache/arrow-rs/pull/5318#discussion_r1465608971


##########
arrow-json/src/writer/encoder.rs:
##########
@@ -31,7 +31,13 @@ pub struct EncoderOptions {
     pub explicit_nulls: bool,
 }
 
+/// A trait to format array values as JSON values
+///
+/// Nullability is handled by the caller to allow encoding nulls implicitly, 
i.e. `{}` instead of `{"a": null}`
 pub trait Encoder {
+    /// Encode the non-null value at index `idx` to `out`
+    ///
+    /// The behaviour is unspecified if `idx` corresponds to a null index

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to