Jefffrey commented on code in PR #5318:
URL: https://github.com/apache/arrow-rs/pull/5318#discussion_r1463978292
##########
arrow-json/src/writer.rs:
##########
@@ -1564,9 +1575,9 @@ mod tests {
r#"{"a":{"list":[1,2]},"b":{"list":[1,2]}}
{"a":{"list":[null]},"b":{"list":[null]}}
{"a":{"list":[]},"b":{"list":[]}}
-{"a":null,"b":{"list":[3,null]}}
+{"b":{"list":[3,null]}}
Review Comment:
I think when I worked on #5133 I just forgot to consider my previous work
for writing explicit nulls in #5065.
This fix makes sense; the only case where we should write nulls if
`explicit_nulls` is set to `false` (i.e. the default) is for list values, and
nothing else, I believe. This falls in line with that :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
