peter-toth commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1913614108
Actually, one more think came into my mind that there is this issue with `Transformed` enum: https://github.com/apache/arrow-datafusion/pull/8835 and if we want to keep and fix it (see conversation on the ticket) it would also require change in `TreeNode::rewrite()` / `TreeNodeRewriter` signature. If for some reason we don't want to make API changes incrementally then we might need incorporate that one as well. IMO there is one more option we could do: because both supporting `Stop` in transform and making `Transformed` useful are both new features we could also change the APIs to its final form in this PR (with documenting the limitations) and add implementations in it follow-up PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
