peter-toth commented on code in PR #8891:
URL: https://github.com/apache/arrow-datafusion/pull/8891#discussion_r1469535278
##########
datafusion/expr/src/tree_node/expr.rs:
##########
@@ -130,13 +130,13 @@ impl TreeNode for Expr {
for child in children {
match op(child)? {
- VisitRecursion::Continue => {}
- VisitRecursion::Skip => return Ok(VisitRecursion::Continue),
- VisitRecursion::Stop => return Ok(VisitRecursion::Stop),
+ TreeNodeRecursion::Continue => {}
+ TreeNodeRecursion::Skip => return
Ok(TreeNodeRecursion::Continue),
+ TreeNodeRecursion::Stop => return Ok(TreeNodeRecursion::Stop),
Review Comment:
Fixed this in
https://github.com/apache/arrow-datafusion/pull/8891/commits/c52f134569b85b37d20c547898a2bf0eda82b5f6
in this PR, but technically this should be a follow-up PR to
https://github.com/apache/arrow-datafusion/pull/8817.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
