CurtHagenlocher commented on code in PR #1507:
URL: https://github.com/apache/arrow-adbc/pull/1507#discussion_r1475479110
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -185,6 +186,33 @@ static IArrowReader ReadChunk(BigQueryReadClient
readClient, string streamName)
{
options.AllowLargeResults = true ?
keyValuePair.Value.ToLower().Equals("true") : false;
}
+ if(keyValuePair.Key ==
BigQueryParameters.LargeResultsDestinationTable)
+ {
+ string destinationTable = keyValuePair.Value;
+
+ if (!destinationTable.Contains("."))
+ throw new
InvalidOperationException($"{BigQueryParameters.LargeResultsDestinationTable}
is invalid");
+
+ string projectId = string.Empty;
+ string datasetId = string.Empty;
+ string tableId = string.Empty;
+
+ List<string> segments =
destinationTable.Split('.').Where(x => x.Length > 0).ToList();
Review Comment:
I don't think "a....b....c" should be allowed.
In principle, should this follow BigQuery identifier rules for e.g.
escaping? Is there a function in the Google libraries to parse table names.
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -1014,6 +1032,10 @@ public override AdbcStatement CreateStatement()
{
options[keyValuePair.Key] = keyValuePair.Value;
}
+ if(keyValuePair.Key ==
BigQueryParameters.LargeResultsDestinationTable)
Review Comment:
nit: space before paren to match the other tests
Unrelated to this specific change, does the ADBC spec say anything about
case-sensitivity of options? For ODBC/JDBC/ADO.NET, connection string keys are
usually case-insensitive.
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -185,6 +186,33 @@ static IArrowReader ReadChunk(BigQueryReadClient
readClient, string streamName)
{
options.AllowLargeResults = true ?
keyValuePair.Value.ToLower().Equals("true") : false;
}
+ if(keyValuePair.Key ==
BigQueryParameters.LargeResultsDestinationTable)
Review Comment:
nit: space before paren
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
