CurtHagenlocher commented on code in PR #1507:
URL: https://github.com/apache/arrow-adbc/pull/1507#discussion_r1476752673
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -185,6 +186,33 @@ static IArrowReader ReadChunk(BigQueryReadClient
readClient, string streamName)
{
options.AllowLargeResults = true ?
keyValuePair.Value.ToLower().Equals("true") : false;
}
+ if(keyValuePair.Key ==
BigQueryParameters.LargeResultsDestinationTable)
+ {
+ string destinationTable = keyValuePair.Value;
+
+ if (!destinationTable.Contains("."))
+ throw new
InvalidOperationException($"{BigQueryParameters.LargeResultsDestinationTable}
is invalid");
+
+ string projectId = string.Empty;
+ string datasetId = string.Empty;
+ string tableId = string.Empty;
+
+ List<string> segments =
destinationTable.Split('.').Where(x => x.Length > 0).ToList();
Review Comment:
Sorry, I didn't do a great job explaining this feedback. What I meant was
that this test would allow me to pass a..b..c (that is a dot dot be dot dot c)
and have it be treated the same way as a.b.c (a dot b dot c) and that seems
wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
